Always install into a python venv in ci containers #12663
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
areusch
force-pushed
the
tvm-venvs
branch
2 times, most recently
from
8b2922d
to
89f9a53
Compare
|
Addresses #12608 |
areusch
force-pushed
the
tvm-venvs
branch
2 times, most recently
from
02c0eb7
to
16bff01
Compare
areusch
commented
Sep 2, 2022
docker/python/freeze-dependencies.sh
Outdated
| @@ -1,4 +1,4 @@ | |||
| #!/bin/bash | |||
| #!/bin/bash -eux | |||
| # Licensed to the Apache Software Foundation (ASF) under one | |||
There was a problem hiding this comment.
oops, rm this file and freeze_deps.py, they are part of a follow-on
driazati
reviewed
Sep 2, 2022
|
|
||
| COPY install/ubuntu_install_cmake_source.sh /install/ubuntu_install_cmake_source.sh | ||
| # Globally disable pip cache |
There was a problem hiding this comment.
Suggested change
| # Globally disable pip cache |
| @@ -0,0 +1,3 @@ | |||
| pip | |||
There was a problem hiding this comment.
why are there separate requirements.txts per Python version?
| lsb-core | ||
|
|
||
| release=$(lsb_release -sc) | ||
| if [ "${release}" == "bionic" ]; then |
There was a problem hiding this comment.
What if we use miniconda instead of the distribution's Python + venv? The end result would be the same but we would be able to say "we use version X of Python in CI" instead of "it depends"
There was a problem hiding this comment.
When I was migrating teams off of conda I used pyenv which would compose into our system with Poetry?
|
The list below shows some tests that ran in main 546a7da but were skipped in the CI build of 5775327: A detailed report of ran tests is here. |
|
@driazati i think this is finally ready |
|
Im hopeful that #12738 will be merged once CI gets green. Happy to merge this just after that. |
|
@leandron happy to hold off til then |
mehrdadh
reviewed
Sep 9, 2022
leandron
approved these changes
Sep 12, 2022
ashutosh-arm
added a commit
to ashutosh-arm/tvm
that referenced
this pull request
Sep 14, 2022
Following change introduced installing python dependencies inside virtual environments: apache#12663 Previous to this fix, a different version of python was being picked up that didn't catch the issues fixed in this commit. Change-Id: Ie290d9474a799311e07d293fa1b8299326b11661
leandron
pushed a commit
that referenced
this pull request
Sep 14, 2022
Following change introduced installing python dependencies inside virtual environments: #12663 Previous to this fix, a different version of python was being picked up that didn't catch the issues fixed in this commit. Change-Id: Ie290d9474a799311e07d293fa1b8299326b11661
This was referenced Sep 15, 2022
driazati
pushed a commit
that referenced
this pull request
Sep 16, 2022
Recently virtual environments were introduced in the docker images which was a great contribution to localize errors: #12663. In this fix, link to the caffe is created inside this virtual env instead of adding it to the system path of python. This fix also removes importing request package where not needed. Fixes #12663
xinetzone
pushed a commit
to daobook/tvm
that referenced
this pull request
Nov 25, 2022
This PR changes all ci_ to install TVM Python dependencies in a virtualenv separate from the system Python dependencies. Sets the stage for adding the poetry-based dependency generator to the CI container build process. * Always install into a python venv in ci containers. * Respect Dockerfile ENV PATH modifications in docker/bash.sh lookups.
xinetzone
pushed a commit
to daobook/tvm
that referenced
this pull request
Nov 25, 2022
) Following change introduced installing python dependencies inside virtual environments: apache#12663 Previous to this fix, a different version of python was being picked up that didn't catch the issues fixed in this commit. Change-Id: Ie290d9474a799311e07d293fa1b8299326b11661
xinetzone
pushed a commit
to daobook/tvm
that referenced
this pull request
Nov 25, 2022
Recently virtual environments were introduced in the docker images which was a great contribution to localize errors: apache#12663. In this fix, link to the caffe is created inside this virtual env instead of adding it to the system path of python. This fix also removes importing request package where not needed. Fixes apache#12663
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes all ci_ to install TVM Python dependencies in a virtualenv separate from the system Python dependencies. This PR sets the stage for adding the poetry-based dependency generator to the CI container build process.